[NFC] Add more overview docs for stack switching #7806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Aug 8, 2025
| // unwind an If instruction then we note which arm of the If we unwound | ||
| // from, and then when we re-wind we enter that proper arm. For a Block, | ||
| // we can note the index we had executed up to, etc. | ||
| // * For values, we just save them (see below on |valueStack| however, as we |
There was a problem hiding this comment.
Maybe note that this will be done automatically and generically in visit, so the individual visitors do not need to worry about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions with @dschuff and @tlively I realized I might be able to
explain the stack switching approach better, so I wrote this PR.